Skip to content

Conversation

yozachar
Copy link
Collaborator

@yozachar yozachar commented Mar 21, 2023

  • moves pre-commit to hooks group
  • uses isort to add grouping comments, instead of ignoring them
  • __init__.py is ignored by isort for documentation
  • fix missing -*- coding: utf-8 -*- annotations
  • update tox configuration in pyproject.toml
  • in GitHub actions, main.yml:
    • changed CI job name to PreflightChecks
    • updated poetry version to 1.4.1
    • runs tox with strategy-matrix
  • in pages.yml:
    • updated poetry version to 1.4.1
    • fix typos
  • makes flake8 ignore .venv

This PR will be closed in an hour.

@yozachar yozachar added review PR: Can be reviewed development Issue/PR: Modification in workflows, packaging, etc. labels Mar 21, 2023
@yozachar yozachar self-assigned this Mar 21, 2023
@yozachar yozachar force-pushed the workshop branch 4 times, most recently from 209db05 to 7d8b035 Compare March 21, 2023 03:46
- moves `pre-commit` to `hooks` group
- uses `isort` to add grouping comments, instead of ignoring them
- `__init__.py` is ignored by `isort` for documentation
- fix missing `-*- coding: utf-8 -*-` annotations
- update `tox` configuration in `pyproject.toml`
- in GitHub actions, `main.yml`:
	- changed CI job name to `PreflightChecks`
	- updated poetry version to `1.4.1`
	- runs `tox` with strategy-matrix
- in `pages.yml`:
	- updated poetry version to `1.4.1`
	- fix typos
- makes flake8 ignore `.venv`
@yozachar
Copy link
Collaborator Author

There is a redundant tox run for container's python version when using strategy matrix. It will be dealt with later.

@yozachar yozachar merged commit 664b705 into python-validators:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Issue/PR: Modification in workflows, packaging, etc. review PR: Can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant